[REVIEW] Create is_integer/is_float functions for checking characters before calling to_integers/to_floats #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
changed the title
davidwendt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #4863 +/- ##
============================================
Coverage 88.50% 88.50%
============================================
Files 54 54
Lines 10124 10124
============================================
Hits 8960 8960
Misses 1164 1164
Continue to review full report at Codecov.
|
cwharris
approved these changes
Apr 9, 2020
jrhemstad
requested changes
Apr 13, 2020
codereport
suggested changes
Apr 16, 2020
harrism
reviewed
Apr 16, 2020
jrhemstad
approved these changes
Apr 16, 2020
codereport
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs added to help fix #2707 and tangentially #4850 and similar issues.
Generally, most libcudf APIs operate in bad-data-in/bad-data-out mode and do not perform checking on individual column elements since this can be unnecessarily costly to performance. And even operations that do validate data values normally provide a parameter to skip that checking. The Python cudf layer tries to report invalid data rather than just return bad data per consistency with Pandas and other Python libraries.
This PR adds two APIs (
is_integer()andis_float()) that can be used optionally before callingto_integers()andto_floats()respectively to check the characters are valid for conversion. This allows the Python code to report an appropriate error and even identify the failing strings.Note: The existing
isnumeric()andisdecimal()are insufficient because neither checks for sign character, decimal pointer, scientific notation as appropriate.The new APIs will return a column of booleans that indicate which strings are invalid for conversion.
This PR will also includes tests for these APIs.