Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix device_scalar::get errors cause by rmm#167 #3211

Merged
merged 5 commits into from
Oct 31, 2019
Merged

fix device_scalar::get errors cause by rmm#167 #3211

merged 5 commits into from
Oct 31, 2019

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Oct 24, 2019 •
edited
Loading

Fixes a breaking change caused by rapidsai/rmm#167, so this PR's build will fail until that is merged.

@cwharris cwharris requested a review from a team as a code owner October 24, 2019 21:31
@cwharris cwharris mentioned this pull request Oct 24, 2019
Merged
@cwharris cwharris added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond libcudf++ labels Oct 24, 2019
@cwharris cwharris requested a review from harrism October 31, 2019 02:11
@harrism
Copy link
Member

harrism commented Oct 31, 2019

/var/lib/jenkins/workspace/rapidsai/gpuci/cudf/prb/cudf-gpu-build_2/cpp/src/bitmask/null_mask.cu(171): error: class "rmm::device_scalar<cudf::size_type>" has no member "data"

@harrism
Copy link
Member

harrism commented Oct 31, 2019

RMM packages must not be updated...

@harrism
Copy link
Member

harrism commented Oct 31, 2019

rerun tests

3 similar comments
@harrism
Copy link
Member

harrism commented Oct 31, 2019

rerun tests

@cwharris
Copy link
Contributor Author

rerun tests

@cwharris
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #3211 into branch-0.11 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.11    #3211   +/-   ##
============================================
  Coverage        87.13%   87.13%           
============================================
  Files               49       49           
  Lines             9269     9269           
============================================
  Hits              8077     8077           
  Misses            1192     1192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a116d7...69f2e35. Read the comment docs.

@cwharris cwharris merged commit dc7ce3b into rapidsai:branch-0.11 Oct 31, 2019
@cwharris cwharris deleted the cudf-fix-device_scalar_get branch December 21, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwharris @harrism