Check num_children() == 0
in Column.from_column_view
#17193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where
Column.from_column_view
is not verifying the existence of a string column's offsets child column prior to accessing it, resulting in a segmentation fault when passing acolumn_view
fromColumn.view()
toColumn.from_column_view(...)
.The issue can be reproduced with:
where
back_and_forth
is defined as:I don't have the expertise to write the appropriate tests for this without introducing the
back_and_forth
function as an API, which seems undesirable.Checklist