Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove includes suggested by include-what-you-use #17170

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 24, 2024

Description

This PR cherry-picks out the suggestions from IWYU generated in #17078.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2024
@vyasr vyasr self-assigned this Oct 24, 2024
@vyasr vyasr requested a review from a team as a code owner October 24, 2024 16:42
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 24, 2024
@bdice
Copy link
Contributor

bdice commented Oct 24, 2024

@vyasr Can we confirm if this has any effect on clean build times?

@vyasr
Copy link
Contributor Author

vyasr commented Oct 24, 2024

Since wheel builds are not currently sccaching at all, a quick test would be to see how the wheel-build-libcudf runtime compares to another recent PR (say #17168).

@vyasr
Copy link
Contributor Author

vyasr commented Oct 24, 2024

Unfortunately I think those build times are too noisy to derive much information from. A clean local build may be the only way to collect that information reliably.

@bdice
Copy link
Contributor

bdice commented Oct 24, 2024

That's fine. I am happy to accept this as an improvement without hard evidence of decreasing build times. I don't think it is worth the engineering time to answer that definitively.

@davidwendt
Copy link
Contributor

I also tried this locally on a full build (cleared ccache) and did not see any changes in the build time.

@vyasr
Copy link
Contributor Author

vyasr commented Oct 25, 2024

Cool thanks for checking. Whether or not we move forward with #17078, I think we might as well merge this PR as a simple clean up.

@vyasr
Copy link
Contributor Author

vyasr commented Oct 28, 2024

@davidwendt could you please approve this if you are happy with it based on our discussion from today's meeting?

@vyasr
Copy link
Contributor Author

vyasr commented Oct 28, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1ad9fc1 into rapidsai:branch-24.12 Oct 28, 2024
102 checks passed
@vyasr vyasr deleted the feat/iwyu_suggestions branch October 28, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants