Migrate CSV writer to pylibcudf #17163
Merged
+462
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
github-actions
bot
added
Python
Matt711
commented
Oct 24, 2024
Matt711
commented
Oct 24, 2024
Matt711
changed the title
Matt711
commented
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
mroeschke
reviewed
Nov 7, 2024
Matt711
commented
Nov 15, 2024
3 tasks
wence-
requested changes
Nov 19, 2024
| return csv_options | ||
|
|
||
|
|
||
| def write_csv( |
There was a problem hiding this comment.
Can this (should this? @vyasr) be a cpdef function?
There was a problem hiding this comment.
Yes. We've been cpdef'ing them, so I did it here too
There was a problem hiding this comment.
I think it's good practice to do it consistently everywhere to enable full Cython usage. For I/O it's probably less important in the grand scheme of things since that shouldn't propagate bad typing afterwards in any way, but consistency helps.
3 tasks
mroeschke
approved these changes
Nov 20, 2024
vyasr
approved these changes
Nov 21, 2024
|
/merge |
1 similar comment
|
/merge |
wence-
reviewed
Nov 21, 2024
Comment on lines
+64
to
+76
| class CsvWriterOptionsBuilder: | ||
| def __init__(self): ... | ||
| def names(self, names: list) -> CsvWriterOptionsBuilder: ... | ||
| def na_rep(self, val: str) -> CsvWriterOptionsBuilder: ... | ||
| def include_header(self, val: bool) -> CsvWriterOptionsBuilder: ... | ||
| def rows_per_chunk(self, val: int) -> CsvWriterOptionsBuilder: ... | ||
| def line_terminator(self, term: str) -> CsvWriterOptionsBuilder: ... | ||
| def inter_column_delimiter( | ||
| self, delim: str | ||
| ) -> CsvWriterOptionsBuilder: ... | ||
| def true_value(self, val: str) -> CsvWriterOptionsBuilder: ... | ||
| def false_value(self, val: str) -> CsvWriterOptionsBuilder: ... | ||
| def build(self) -> CsvWriterOptions: ... |
There was a problem hiding this comment.
nit: Let's do this in a followup, these should return Self (from typing). Edit: apart from build.
wence-
reviewed
Nov 21, 2024
wence-
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist