-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI Support for Multi-line Delimiters and Include Test #17139
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-24.12
from
SurajAralihalli:update_regex_program
Oct 23, 2024
Merged
Add JNI Support for Multi-line Delimiters and Include Test #17139
rapids-bot
merged 10 commits into
rapidsai:branch-24.12
from
SurajAralihalli:update_regex_program
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
SurajAralihalli
changed the title
Update regex program
Add JNI Support for Multi-line Delimiters and Include Test
Oct 21, 2024
SurajAralihalli
added
Spark
Functionality that helps Spark RAPIDS
non-breaking
Non-breaking change
labels
Oct 21, 2024
Signed-off-by: Suraj Aralihalli <[email protected]>
mythrocks
reviewed
Oct 22, 2024
mythrocks
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for documentation of the new behaviour.
Signed-off-by: Suraj Aralihalli <[email protected]>
mythrocks
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
revans2
approved these changes
Oct 23, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the necessary changes to the cuDF jni to support the issue described in NVIDIA/spark-rapids#11554. For further information, refer to the details in the comment.
Issue #15961 adds support for handling multiple line delimiters. This PR extends that functionality to JNI, which was previously missing, and also includes a test to validate the changes.
Checklist