Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNI Support for Multi-line Delimiters and Include Test #17139

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

SurajAralihalli
Copy link
Contributor

Description

This PR introduces the necessary changes to the cuDF jni to support the issue described in NVIDIA/spark-rapids#11554. For further information, refer to the details in the comment.

Issue #15961 adds support for handling multiple line delimiters. This PR extends that functionality to JNI, which was previously missing, and also includes a test to validate the changes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
@SurajAralihalli SurajAralihalli requested a review from a team as a code owner October 21, 2024 23:22
@github-actions github-actions bot added the Java Affects Java cuDF API. label Oct 21, 2024
@SurajAralihalli SurajAralihalli changed the title Update regex program Add JNI Support for Multi-line Delimiters and Include Test Oct 21, 2024
@SurajAralihalli SurajAralihalli added Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Oct 21, 2024
Signed-off-by: Suraj Aralihalli <[email protected]>
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for documentation of the new behaviour.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SurajAralihalli
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f0c6a04 into rapidsai:branch-24.12 Oct 23, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants