Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NVText Normalizing APIs to Pylibcudf #17072

Merged
merged 24 commits into from
Oct 17, 2024
Merged

Migrate NVText Normalizing APIs to Pylibcudf #17072

merged 24 commits into from
Oct 17, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 12, 2024 •
edited
Loading

Description

Apart of #15162.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Oct 12, 2024
@Matt711 Matt711 changed the title Pylibcudf nvtext normalize Migrate NVText Normalizing APIs to Pylibcudf Oct 12, 2024
@Matt711 Matt711 mentioned this pull request Oct 12, 2024
Open
@Matt711 Matt711 self-assigned this Oct 12, 2024
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 12, 2024
@Matt711 Matt711 changed the title Migrate NVText Normalizing APIs to Pylibcudf [WIP] Migrate NVText Normalizing APIs to Pylibcudf Oct 12, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 13, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 13, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 17, 2024

/ok to test

@Matt711 Matt711 marked this pull request as ready for review October 17, 2024 00:30
@Matt711 Matt711 requested a review from a team as a code owner October 17, 2024 00:30
@Matt711 Matt711 changed the title [WIP] Migrate NVText Normalizing APIs to Pylibcudf Migrate NVText Normalizing APIs to Pylibcudf Oct 17, 2024
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Oct 17, 2024
bdice
bdice requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one blocking request on the tests.

python/pylibcudf/pylibcudf/tests/test_nvtext_normalize.py Outdated Show resolved Hide resolved
@Matt711 Matt711 requested a review from bdice October 17, 2024 20:08
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 17, 2024

/ok to test

bdice
bdice approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a PR description before merging!

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 17, 2024

Please write a PR description before merging!

Thanks!

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit ce93c36 into rapidsai:branch-24.12 Oct 17, 2024
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @bdice