Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect groupby.nunique(dropna=False) #16921

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Respect groupby.nunique(dropna=False) #16921

merged 3 commits into from
Sep 26, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #16861

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 25, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 25, 2024 22:30
Matt711
Matt711 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/cudf/cudf/_lib/aggregation.pyx Outdated Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d69e4b6 into rapidsai:branch-24.12 Sep 26, 2024
96 checks passed
@mroeschke mroeschke deleted the bug/gb/nunique branch September 26, 2024 18:17
@mroeschke mroeschke mentioned this pull request Sep 26, 2024
Closed
copy-pr-bot bot pushed a commit that referenced this pull request Sep 28, 2024
@mroeschke @lamarrr
Respect groupby.nunique(dropna=False) (#16921)
fe9b821 
closes #16861

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Matthew Murray (https://github.com/Matt711)

URL: #16921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @Matt711