Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in column_factories.hpp comment from 'depth 1' to 'depth 2' #16700

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix typo in column_factories.hpp comment from 'depth 1' to 'depth 2' #16700

merged 2 commits into from
Sep 3, 2024

Conversation

a-hirota
Copy link
Contributor

@a-hirota a-hirota commented Aug 30, 2024 •
edited
Loading

Description

This PR fixes a typo in the cpp/include/cudf/column/column_factories.hpp file. The comment incorrectly mentioned "data (depth 1)" instead of "data (depth 2)". This correction improves code clarity and documentation accuracy.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@a-hirota a-hirota requested a review from a team as a code owner August 30, 2024 00:26
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 30, 2024
@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 30, 2024
@davidwendt
Copy link
Contributor

/ok to test

@davidwendt
Copy link
Contributor

/ok to test

@ttnghia
Copy link
Contributor

ttnghia commented Sep 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0097b45 into rapidsai:branch-24.10 Sep 3, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hirota @davidwendt @ttnghia