Remove java ColumnView.copyWithBooleanColumnAsValidity #16660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added
bug
abellina
approved these changes
Aug 26, 2024
| @@ -6395,46 +6395,6 @@ void testReplaceSameIndexColumnInStruct() { | |||
| assertTrue(e.getMessage().contains("Duplicate mapping found for replacing child index")); | |||
| } | |||
|
|
|||
| @Test | |||
hyperbolic2346
approved these changes
Aug 27, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This depends on NVIDIA/spark-rapids#11399
Essentially ifElse is faster than this API and this API is not safe to use generically.
NVIDIA/spark-rapids#11397 (comment)
So I am removing it after replacing all calls to it with calls to
ifElse/cudf::copy_if_elseChecklist