Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for binops between two differently sized DecimalDtypes #16638

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Currently cudf Python has some custom logic for determining the resulting dtype of a binop between 2 decimal dtypes since Python decimal dtype support precision and libcudf doesn't. But libcudf does require that the 2 operands have the same decimal type when calculating the binop, so we must ensure the inputs are cast to the same, resulting dtype.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 21, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 21, 2024 23:02
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d0e5cdf into rapidsai:branch-24.10 Aug 27, 2024
92 checks passed
@mroeschke mroeschke deleted the bug/decimal/binops branch August 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants