Avoid unnecessary Index cast in IndexedFrame.index setter
#15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
added
bug
mroeschke
reviewed
May 23, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
|
Could we also add this simple test in @pytest.mark.parametrize("index", [cudf.Index([1]), cudf.RangeIndex(1), cudf.MultiIndex(levels=[[0]], codes=[[0]])])
def test_index_assignment_no_shallow_copy(index):
df = cudf.DataFrame(range(1))
df.index = index
assert df.index is index |
3 tasks
|
On recommendations from @mroeschke, retargeted this to 24.08 and opened #15844 with a simpler unblocker for the dask-cuda breakage for the sake of time. |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
Lighter weight alternative to #15843 to unblock dask-cuda's breakage. Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Vyas Ramasubramani (https://github.com/vyasr) URL: #15844
mroeschke
approved these changes
May 24, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triaging recent dask-cuda breakage led me to #15781, where it seems like the passing of an index object directly to the
IndexedFrame.indexsetter (and therefore, wrapping of this index in anIndex()constructor) has caused proxifying issues on dask-cuda's end.cc @rjzamora @mroeschke
Checklist