Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cat.as_ordered not propogating correct size #15780

Merged
merged 5 commits into from
May 21, 2024
Merged

Fix cat.as_ordered not propogating correct size #15780

merged 5 commits into from
May 21, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #15778

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels May 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner May 18, 2024 00:02
@mroeschke mroeschke requested review from vyasr and isVoid May 18, 2024 00:02
@vyasr vyasr mentioned this pull request May 20, 2024
Open
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b4daa16 into rapidsai:branch-24.06 May 21, 2024
71 checks passed
@rjzamora
Copy link
Member

Thanks @mroeschke !

@mroeschke mroeschke deleted the bug/as_ordered/sliced branch May 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Calling cat.as_ordered does not work on a sliced column
4 participants
@mroeschke @galipremsagar @rjzamora @wence-