Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word-based nvtext::minhash function #15368

Merged
merged 82 commits into from
Sep 17, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Mar 21, 2024

Description

Experimental implementation for #15055
The input is a lists column of strings where each string in each row is expected as a word to be hashed. The minimum hash for that row is returned in a lists column where each row contains a minhash per input hash seed.
Here the caller is expected to produce the words to be hashed.

std::unique_ptr<cudf::column> word_minhash(
  cudf::lists_column_view const& input,
  cudf::device_span<uint32_t const> seeds,
  rmm::cuda_stream_view stream,
  rmm::device_async_resource_ref mr);

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Mar 21, 2024
@davidwendt davidwendt self-assigned this Mar 21, 2024
@davidwendt davidwendt changed the base branch from branch-24.06 to branch-24.08 May 21, 2024 14:24
@github-actions github-actions bot removed the pylibcudf Issues specific to the pylibcudf package label Aug 19, 2024
@davidwendt davidwendt marked this pull request as ready for review September 3, 2024 17:11
@davidwendt davidwendt requested review from a team as code owners September 3, 2024 17:11
cpp/benchmarks/text/word_minhash.cpp Outdated Show resolved Hide resolved
cpp/include/nvtext/minhash.hpp Outdated Show resolved Hide resolved
cpp/include/nvtext/minhash.hpp Outdated Show resolved Hide resolved
cpp/include/nvtext/minhash.hpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 23351aa into rapidsai:branch-24.10 Sep 17, 2024
105 checks passed
@davidwendt davidwendt deleted the word-minhash branch September 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants