Update to CCCL 2.2.0. #14576
Merged
Update to CCCL 2.2.0. #14576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
This was referenced Dec 5, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
This PR makes cudf compatible with Thrust 2 by adding `cuda::proclaim_return_type`, but does not upgrade the version of Thrust/CCCL just yet. Currently we use libcudacxx 2.1.0, which makes `cuda::proclaim_return_type` available, but we still use Thrust 1.17.2 which doesn't require device lambdas to have proclaimed return types. This diff is separated out from #14576 and reduces the diff we must carry in #14576 -- which should contain only packaging changes / version updates for the CCCL 2 migration. This PR is **nonbreaking**, while #14576 will be **breaking**. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: #14577
26 tasks
karthikeyann
pushed a commit
to karthikeyann/cudf
that referenced
this pull request
Dec 12, 2023
This PR makes cudf compatible with Thrust 2 by adding `cuda::proclaim_return_type`, but does not upgrade the version of Thrust/CCCL just yet. Currently we use libcudacxx 2.1.0, which makes `cuda::proclaim_return_type` available, but we still use Thrust 1.17.2 which doesn't require device lambdas to have proclaimed return types. This diff is separated out from rapidsai#14576 and reduces the diff we must carry in rapidsai#14576 -- which should contain only packaging changes / version updates for the CCCL 2 migration. This PR is **nonbreaking**, while rapidsai#14576 will be **breaking**. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: rapidsai#14577
bdice
force-pushed
the
cccl-2.2.0
branch
3 times, most recently
from
d077b68
to
1481b0d
Compare
bdice
commented
Dec 18, 2023
ci/build_cpp.sh
Outdated
Comment on lines
12
to
13
| LIBRMM_CHANNEL=$(rapids-get-pr-conda-artifact rmm 1404 cpp) | ||
|
|
There was a problem hiding this comment.
I will revert changes to CI scripts that use upstream artifacts before merging.
bdice
commented
Dec 18, 2023
fetch_rapids.cmake
Outdated
Comment on lines
14
to
15
| set(rapids-cmake-repo bdice/rapids-cmake) | ||
| set(rapids-cmake-branch cuco-cccl-2.2.0) |
There was a problem hiding this comment.
I will revert this before merging. Depends on NVIDIA/cuCollections#404 merging, and rapids-cmake being updated to use that commit in versions.json.
vyasr
requested changes
Dec 18, 2023
Co-authored-by: Vyas Ramasubramani <[email protected]>
vyasr
approved these changes
Dec 18, 2023
raydouglass
approved these changes
Dec 19, 2023
bdice
added
improvement
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates cuDF to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update.
Depends on #14577.
Replaces #13222.
Checklist