Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused parameter warning/error in parquet/page_data.cu #13367

Merged
merged 3 commits into from
May 17, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented May 17, 2023

Description

Fixed unused parameters warning/error in the parquet/page_data.cu:

/cudf/cpp/src/io/parquet/page_data.cu(171): error #177-D: parameter "is_decode_step" was declared but never referenced
          detected during:
            instantiation of "__nv_bool cudf::io::parquet::gpu::<unnamed>::setupLocalPageInfo(cudf::io::parquet::gpu::<unnamed>::page_state_s *, const cudf::io::parquet::gpu::PageInfo *, cudf::device_span<const cudf::io::parquet::gpu::ColumnChunkDesc, 18446744073709551615UL>, size_t, size_t, __nv_bool, cudf::io::parquet::gpu::rle_stream<level_t> *) [with level_t=uint8_t]" 
(1825): here
            instantiation of "void cudf::io::parquet::gpu::<unnamed>::gpuComputePageSizes<lvl_buf_size,level_t>(cudf::io::parquet::gpu::PageInfo *, cudf::device_span<const cudf::io::parquet::gpu::ColumnChunkDesc, 18446744073709551615UL>, size_t, size_t, __nv_bool, __nv_bool) [with lvl_buf_size=2048, level_t=uint8_t]" 
(2197): here

/cudf/cpp/src/io/parquet/page_data.cu(172): error #177-D: parameter "decoders" was declared but never referenced
          detected during:
            instantiation of "__nv_bool cudf::io::parquet::gpu::<unnamed>::setupLocalPageInfo(cudf::io::parquet::gpu::<unnamed>::page_state_s *, const cudf::io::parquet::gpu::PageInfo *, cudf::device_span<const cudf::io::parquet::gpu::ColumnChunkDesc, 18446744073709551615UL>, size_t, size_t, __nv_bool, cudf::io::parquet::gpu::rle_stream<level_t> *) [with level_t=uint8_t]" 
(1825): here
            instantiation of "void cudf::io::parquet::gpu::<unnamed>::gpuComputePageSizes<lvl_buf_size,level_t>(cudf::io::parquet::gpu::PageInfo *, cudf::device_span<const cudf::io::parquet::gpu::ColumnChunkDesc, 18446744073709551615UL>, size_t, size_t, __nv_bool, __nv_bool) [with lvl_buf_size=2048, level_t=uint8_t]" 
(2197): here

2 errors detected in the compilation of "/cudf/cpp/src/io/parquet/page_data.cu".

Removing the parameters seemed to work and gtests are passing.
This was found by building with nvcc 11.5.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 17, 2023
@davidwendt davidwendt requested a review from a team as a code owner May 17, 2023 15:16
@davidwendt davidwendt self-assigned this May 17, 2023
Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detritus from some optimization experiments. Thanks for the fix.

@vuule
Copy link
Contributor

vuule commented May 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit e4d2a23 into rapidsai:branch-23.06 May 17, 2023
@davidwendt davidwendt deleted the bug-unused-vars branch July 31, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants