Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variables/parameters in parquet/writer_impl.cu #13263

Merged
merged 1 commit into from
May 2, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented May 2, 2023

Description

Fix some unused variables/parameters warnings introduced by #13076.
My old nvcc 11.5 compiler found these. Removing some of these found functions that could be removed as well.
Some variables/parameters are now declared with [[maybe_unused]]

/cudf/cpp/src/io/parquet/writer_impl.cu(575): error #177-D: variable "data_col_type" was declared but never referenced

/cudf/cpp/src/io/parquet/writer_impl.cu(906): error #177-D: parameter "stream" was declared but never referenced

/cudf/cpp/src/io/parquet/writer_impl.cu(908): error #177-D: variable "col" was declared but never referenced

/cudf/cpp/src/io/parquet/writer_impl.cu(1290): error #177-D: parameter "max_page_uncomp_data_size" was declared but never referenced

/cudf/cpp/src/io/parquet/writer_impl.cu(1411): error #177-D: parameter "input" was declared but never referenced

/cudf/cpp/src/io/parquet/writer_impl.cu(1712): error #177-D: variable "dict_info_owner" was declared but never referenced

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 2, 2023
@davidwendt davidwendt self-assigned this May 2, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 2, 2023
@davidwendt davidwendt marked this pull request as ready for review May 2, 2023 11:26
@davidwendt davidwendt requested a review from a team as a code owner May 2, 2023 11:26
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9be347f into rapidsai:branch-23.06 May 2, 2023
@davidwendt davidwendt deleted the parquet-unused-vars branch May 2, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants