Support replace in strings_udf
#12207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
Add udf function for replacing all occurrences of a target string within a source string with a replacement string. This is to support #12207 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - https://github.com/brandon-b-miller URL: #12210
brandon-b-miller
added
3 - Ready for Review
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12207 +/- ##
===============================================
Coverage ? 88.21%
===============================================
Files ? 137
Lines ? 22690
Branches ? 0
===============================================
Hits ? 20017
Misses ? 2673
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shwina
reviewed
Nov 23, 2022
shwina
approved these changes
Nov 23, 2022
|
rerun tests |
davidwendt
reviewed
Nov 29, 2022
Co-authored-by: David Wendt <[email protected]>
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following function in
strings_udf:str.replacePart of #9639