Support equally comparing two different tables in the newly experimental row comparator #10667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
|
@jrhemstad @devavret The new equality comparator seems to be incorrect for sliced input. I still didn't figure out what's wrong. If you uncover anything, please let me know. |
ttnghia
removed
the
improvement
ttnghia
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@bdice If you are working on similar thing, please apply this patch: https://github.com/rapidsai/cudf/pull/10667/files#diff-0743b70282a92785dee8e55adc4099f501b4ed6c20c21e39fe187b2f4f0664a0L560-R562. It is fixing the bug when the input column is sliced. |
|
In addition, I'm still not sure if this (https://github.com/rapidsai/cudf/pull/10667/files#diff-0743b70282a92785dee8e55adc4099f501b4ed6c20c21e39fe187b2f4f0664a0R573-R574) also needs to be fixed by the same way. This needs to be tested too. |
This reverts commit a8a2788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new row comparator (#10164) only added a
self_comparatorutility to compare rows of the same table. This PR addsequality::table_comparatorthat allows equally comparing rows from different tables. Immediate usage of such comparator is for linearly searching a struct scalar in a structs column.In addition, it also fixes the comparator that produces wrong results when the input is sliced.
This PR is required for #10548 and #10656.