Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap CI script shell variables in quotes to fix local testing. #10018

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 11, 2022

This is a tiny PR that wraps shell script variables in quotes. This fixes an issue I saw in the upload script when ${BUILD_MODE} was not set during local testing of the CI environment.

@bdice bdice added bug Something isn't working gpuCI non-breaking Non-breaking change labels Jan 11, 2022
@bdice bdice self-assigned this Jan 11, 2022
@bdice bdice requested a review from a team as a code owner January 11, 2022 15:32
@bdice bdice changed the title Wrap CI script shell variables in quotes to help with local testing. Wrap CI script shell variables in quotes to fix local testing. Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #10018 (af134e2) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10018      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20480     +175     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18346     +171     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc25f3d...af134e2. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Jan 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 88e6a29 into rapidsai:branch-22.02 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants