Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudftestutil no longer propagates compiler flags to external users #10017

Conversation

robertmaynard
Copy link
Contributor

Fixes #9952

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels Jan 11, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner January 11, 2022 15:29
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #10017 (9e35794) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 9e35794 differs from pull request most recent head 173466e. Consider uploading reports for the commit 173466e to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10017      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20471     +166     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18337     +162     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951f630...173466e. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jan 11, 2022

rerun tests

@harrism
Copy link
Member

harrism commented Jan 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a43682e into rapidsai:branch-22.02 Jan 12, 2022
@robertmaynard robertmaynard deleted the bug/remove_cudftestutil_leaking_compiler_flags branch January 13, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudftestutil leaks compile options
3 participants