We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug If I try to concatenate two structs columns with no children columns I get a segfault.
Steps/Code to reproduce bug Apply the patch and run.
diff --git a/cpp/tests/copying/concatenate_tests.cu b/cpp/tests/copying/concatenate_tests.cu index 7d3b7beb2c..e1c3ce1622 100644 --- a/cpp/tests/copying/concatenate_tests.cu +++ b/cpp/tests/copying/concatenate_tests.cu @@ -826,6 +826,19 @@ TEST_F(StructsColumnTest, ConcatenateStructs) cudf::test::expect_columns_equivalent(*result, *expected); } +TEST_F(StructsColumnTest, ConcatenateEmptyStructs) +{ + using namespace cudf::test; + + auto expected = cudf::make_structs_column(10, {}, 0, rmm::device_buffer()); + auto first = cudf::make_structs_column(5, {}, 0, rmm::device_buffer()); + auto second = cudf::make_structs_column(5, {}, 0, rmm::device_buffer()); + + // concatenate + auto result = cudf::concatenate(std::vector<column_view>({*first, *second})); + cudf::test::expect_columns_equivalent(*result, *expected); +} + TEST_F(StructsColumnTest, ConcatenateSplitStructs) { using namespace cudf::test;
Expected behavior It does not crash and ideally produces the correct answer.
The text was updated successfully, but these errors were encountered:
Fix concatenate empty structs (#8947)
ffb37c9
Closes #8929 Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children. Authors: - Alfred Xu (https://github.com/sperlingxx) Approvers: - Nghia Truong (https://github.com/ttnghia) - Mike Wilson (https://github.com/hyperbolic2346) URL: #8947
Fix concatenate empty structs (rapidsai#8947)
012caf8
Closes rapidsai#8929 Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children. Authors: - Alfred Xu (https://github.com/sperlingxx) Approvers: - Nghia Truong (https://github.com/ttnghia) - Mike Wilson (https://github.com/hyperbolic2346) URL: rapidsai#8947
Successfully merging a pull request may close this issue.
Describe the bug
If I try to concatenate two structs columns with no children columns I get a segfault.
Steps/Code to reproduce bug
Apply the patch and run.
Expected behavior
It does not crash and ideally produces the correct answer.
The text was updated successfully, but these errors were encountered: