-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Logging in libcudf #7861
Comments
Similar to rapidsai/rmm#564 I'd like to see the ability for the application to provide a logging sink to better control the handling of any log messages. Emitting uncontrollable messages to stdout or creating files in the current directory will be problematic for some use-cases. Providing a log sink adapter or some similar interface allows the libcudf log messages to be funneled to any existing logging mechanism the app may be using. |
This issue has been labeled |
This issue has been labeled |
Some new potential uses in cuIO: |
Finally revisiting this :) Initial design thoughts:
@jlowe is a libcudf API what you had in mind in your request? It would need to be called before any other libcudf functions to avoid potentially logging with default settings. |
Just a note, spdlog can be used header-only or precompiled. Given that we use it header-only in rmm since rmm itself is header-only, it may not help compile times in libcudf to use its compiled mode here, but if we do go the spdlog route it's worth checking on the compile times before @davidwendt comes after you 😄 |
Now that we have merged #12637, I'd like to close this issue and continue the discussion for additional logging items in new issue(s). |
@GregoryKimball regarding the additional logging items: I opened a PR for cuIO warnings that are not related to integrations #13043. cuIO ntegrations should be covered as well in 23.06. |
Issue #7861 Added the following log messages: - Info message about nvCOMP use for a given compression type (once per type). - Error message when a file cannot be read/written with cuFile, and fallback is disabled (per file). - Info messages about GDS use vs. bounce buffer (per file). Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Nghia Truong (https://github.com/ttnghia) - Karthikeyan (https://github.com/karthikeyann) URL: #13132
Certain libcudf functions need to send warnings to users.
Examples:
These warnings can be part of a log and in general libcudf can have logging similar to RMM.
The text was updated successfully, but these errors were encountered: