Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] cudf::strings::to_fixed_point support scientific notation #7665

Closed
sperlingxx opened this issue Mar 22, 2021 · 2 comments · Fixed by #8234
Closed

[FEA] cudf::strings::to_fixed_point support scientific notation #7665

sperlingxx opened this issue Mar 22, 2021 · 2 comments · Fixed by #8234
Assignees
@davidwendt
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python)

Comments

@sperlingxx
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, cudf::strings::to_fixed_point can not parse input string formatted as scientific notation, such as: 1.76e-3. And scientific notation is widely used in Spark and other kinds of applications.

Describe the solution you'd like
Reinforce string_to_decimal_fn.
@sperlingxx sperlingxx added feature request New feature or request Needs Triage Need team to review and classify labels Mar 22, 2021
@revans2 revans2 added the Spark Functionality that helps Spark RAPIDS label Mar 25, 2021
@revans2 revans2 mentioned this issue Mar 25, 2021
Closed
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Mar 26, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@davidwendt davidwendt added the strings strings issues (C++ and Python) label May 7, 2021
@davidwendt davidwendt self-assigned this May 7, 2021
@davidwendt
Copy link
Contributor

Including this unanswered comment/question here just for historical purposes.
#7285 (comment)
Should have a PR for this ready soon.

@davidwendt davidwendt mentioned this issue May 13, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue May 14, 2021
@davidwendt
Add scientific notation support to cudf::strings::to_fixed_point and …
92a432d 
…cudf::strings::is_fixed_point (#8234)

Closes #7665 
This adds support for converting to fixed-point types from strings containing scientific notation like "1.23E2" and "45.6e-12"
This PR also corresponding updates to the `cudf::strings::is_fixed_point` function as well.
The gtests for these APIs were also updated to include valid and invalid strings as appropriate.

Overall, this was a rewrite of the current internal functors for converting and data validation. Also, common code for both were refactored into an internal base class to minimize maintenance.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Conor Hoekstra (https://github.com/codereport)

URL: #8234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
4 participants
@revans2 @kkraus14 @sperlingxx @davidwendt