-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Broken reference in StringMethod
and CategoricalAccessor
#7320
Comments
The root issue is that when using forward reference in typing annotation, sphinx wasn't able to derive from the package shorthand. (Such as A quick and dirty fix is just to use In Open to suggestions! cc @rapidsai/cudf-python-codeowners |
As an aside, these are a rare case of public APIs with type annotations (because we make heavy use of them internally). I wonder if one solution is simply to separate the implementation and public API into a typed part and untyped shim layer respectively. |
We shouldn't have to make an additional shim layer in order to use type annotations. We should do whatever we need to from the Sphinx side in order to avoid having to add an additional layer of indirection in cuDF. |
Closes #7320 This PR adds an additional preprocessing step in documentation generation. It traverses through the doctree generated by Sphinx and replaces unresolved type short hands with proper target reference, while keeping the shortened name for display text. An additional preprocessing step is added to ignore internal types to APIs facing both internally and externally, such as `cudf.core.column.string.StringColumn` `cupy` API reference is added to intersphinx. Minor changes: - Fixes a small doc bug in `frame.copy` Authors: - Michael Wang (@isVoid) Approvers: - Ashwin Srinath (@shwina) URL: #7416
Closes rapidsai#7320 This PR adds an additional preprocessing step in documentation generation. It traverses through the doctree generated by Sphinx and replaces unresolved type short hands with proper target reference, while keeping the shortened name for display text. An additional preprocessing step is added to ignore internal types to APIs facing both internally and externally, such as `cudf.core.column.string.StringColumn` `cupy` API reference is added to intersphinx. Minor changes: - Fixes a small doc bug in `frame.copy` Authors: - Michael Wang (@isVoid) Approvers: - Ashwin Srinath (@shwina) URL: rapidsai#7416
Report incorrect documentation
Describe the problems or issues found in the documentation
Steps taken to verify documentation is incorrect
run
docs-cudf-python
on branch-0.18Suggested fix for documentation
Add proper reference to the classes
Full error:
The text was updated successfully, but these errors were encountered: