Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Decimal constructor for boxed unscaled values #6795

Open
sperlingxx opened this issue Nov 18, 2020 · 1 comment
Open

[FEA] Decimal constructor for boxed unscaled values #6795

sperlingxx opened this issue Nov 18, 2020 · 1 comment
Assignees
@sperlingxx
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@sperlingxx
Copy link
Contributor

As mentioned in conversation of #6770, it is good to have a decimal constructor for boxed unscaled values, which working with ColumnVector.build.
@sperlingxx sperlingxx added feature request New feature or request Needs Triage Need team to review and classify Java Affects Java cuDF API. labels Nov 18, 2020
@sperlingxx sperlingxx mentioned this issue Nov 18, 2020
Merged
@sperlingxx sperlingxx self-assigned this Nov 18, 2020
@jlowe jlowe removed the Needs Triage Need team to review and classify label Nov 18, 2020
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@sperlingxx sperlingxx mentioned this issue Mar 17, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 23, 2021
@sperlingxx
Java support of casting string from/to decimal (#7623)
4e9241e 
This pull request provided Java side support of casting string from/to decimal, which is required by spark-rapids.

Although parsing of string formatted as scientific notation to decimal has not been supported yet by cuDF, we are able to implement string to decimal conversion at spark-rapids side through a two-steps hack: 
1. casting string to float 
2. casting float to decimal

In addition, this pull request also addressed issue #6795.

Authors:
  - Alfred Xu (@sperlingxx)

Approvers:
  - Robert (Bobby) Evans (@revans2)

URL: #7623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlowe @vyasr @sperlingxx