Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support strings in cudf::shift #3915

Closed
cwharris opened this issue Jan 25, 2020 · 0 comments · Fixed by #8648
Closed

[FEA] Support strings in cudf::shift #3915

cwharris opened this issue Jan 25, 2020 · 0 comments · Fixed by #8648
Assignees
@davidwendt
Labels
1 - On Deck To be worked on next feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)

Comments

@cwharris
Copy link
Contributor

Add string support to cudf::experimental::shift in shift.cu. See #3662 for fixed-width type PR.
@cwharris cwharris added feature request New feature or request 1 - On Deck To be worked on next libcudf Affects libcudf (C++/CUDA) code. labels Jan 25, 2020
@cwharris cwharris self-assigned this Jan 25, 2020
@harrism harrism mentioned this issue Mar 3, 2020
Closed
@cwharris cwharris removed their assignment Aug 16, 2020
@davidwendt davidwendt added the strings strings issues (C++ and Python) label Jun 4, 2021
@davidwendt davidwendt self-assigned this Jun 30, 2021
@davidwendt davidwendt mentioned this issue Jul 2, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #8648 Jul 9, 2021
rapids-bot bot pushed a commit that referenced this issue Jul 9, 2021
@davidwendt
Add strings support to cudf::shift function (#8648)
1b34652 
Closes #3915 

Added strings specialization logic to the current `cudf::shift` API. Rows are shifted by running a transform functions on the offsets and chars child columns to create the output strings column. The gtests are added to the `copying/shift_tests.cpp`

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Nghia Truong (https://github.com/ttnghia)
  - Karthikeyan (https://github.com/karthikeyann)
  - Mark Harris (https://github.com/harrism)

URL: #8648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
1 - On Deck To be worked on next feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add strings support to cudf::shift function davidwendt/cudf
3 participants
@harrism @cwharris @davidwendt