-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] CUDF_VERSION in cudf.h ? #3155
Labels
Comments
OlivierNV
added
feature request
New feature or request
Needs Triage
Need team to review and classify
labels
Oct 18, 2019
kkraus14
added
libcudf
Affects libcudf (C++/CUDA) code.
and removed
Needs Triage
Need team to review and classify
labels
Jan 9, 2020
I believe this is resolved, including |
I don't believe that this exists yet. |
@robertmaynard isn't this trivially solvable now with https://docs.rapids.ai/api/rapids-cmake/stable/command/rapids_cmake_write_version_file/? |
Rapids-cmake would provide the major, minor, and patch defines. That should be sufficient for consuming projects |
rapids-bot bot
pushed a commit
that referenced
this issue
Nov 14, 2024
Resolves #3155. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) URL: #17312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
Changes to cudf functionality may break existing code that relies on cudf. The lack of versioning makes it difficult to have a code base that could support multiple cudf versions.
Describe the solution you'd like
Seems like a CUDF_VERSION, perhaps along with CUDF_VERSION_{MAJOR|MINOR} definitions would be useful. Would also be useful for cudf-io writers for putting cudf version in parquet/orc files.
The text was updated successfully, but these errors were encountered: