Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] CUDF_VERSION in cudf.h ? #3155

Closed
OlivierNV opened this issue Oct 18, 2019 · 4 comments · Fixed by #17312
Closed

[FEA] CUDF_VERSION in cudf.h ? #3155

OlivierNV opened this issue Oct 18, 2019 · 4 comments · Fixed by #17312
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@OlivierNV
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Changes to cudf functionality may break existing code that relies on cudf. The lack of versioning makes it difficult to have a code base that could support multiple cudf versions.

Describe the solution you'd like
Seems like a CUDF_VERSION, perhaps along with CUDF_VERSION_{MAJOR|MINOR} definitions would be useful. Would also be useful for cudf-io writers for putting cudf version in parquet/orc files.

@OlivierNV OlivierNV added feature request New feature or request Needs Triage Need team to review and classify labels Oct 18, 2019
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jan 9, 2020
@GregoryKimball
Copy link
Contributor

I believe this is resolved, including CUDF_VERSION, CUDF_VERSION_MAJOR and CUDF_VERSION_MINOR

@vyasr
Copy link
Contributor

vyasr commented Aug 18, 2023

I don't believe that this exists yet.

@vyasr vyasr reopened this Aug 18, 2023
@vyasr
Copy link
Contributor

vyasr commented Oct 31, 2024

@robertmaynard
Copy link
Contributor

Rapids-cmake would provide the major, minor, and patch defines. That should be sufficient for consuming projects

@vyasr vyasr mentioned this issue Nov 13, 2024
3 tasks
rapids-bot bot pushed a commit that referenced this issue Nov 14, 2024
Resolves #3155.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #17312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants