Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] illegal access error in mixed_join after ODR cleanup PR #16706

Closed
abellina opened this issue Aug 30, 2024 · 1 comment · Fixed by #16708
Closed

[BUG] illegal access error in mixed_join after ODR cleanup PR #16706

abellina opened this issue Aug 30, 2024 · 1 comment · Fixed by #16708
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@abellina
Copy link
Contributor

This PR (merged to 24.10) inadvertently introduced a bug where a template param (has_nulls) is no longer being passed through, and instead we are hardcoding a value. This is yielding illegal access errors since, I believe we claim the column has a validity mask but it doesn't really.

#16603

Problematic lines:

508bdea...f511322#diff-119e81c55e75b3ed49be29077fb6b807718c002608af3373c364bc007dc92b4aR133

508bdea...f511322#diff-0fd89fe429c81ecd37ceb411faae66e527c73cfa4fd98dc3bcbe28bd004adc0fR127
@abellina abellina added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. labels Aug 30, 2024
@abellina
Copy link
Contributor Author

will put up a patch for it

@abellina abellina mentioned this issue Aug 30, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 3, 2024
@abellina
Ensure we pass the has_nulls tparam to mixed_join kernels (#16708)
557aabf 
Fixes #16706

I'll build/test our stack with this change, but it looks like a typo.

If there's a quick unit test we can add I'd be happy to hear recommendations or for someone else to follow on with such a test.

Authors:
  - Alessandro Bellina (https://github.com/abellina)

Approvers:
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)
  - Bradley Dice (https://github.com/bdice)
  - MithunR (https://github.com/mythrocks)

URL: #16708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we pass the has_nulls tparam to mixed_join kernels abellina/cudf
1 participant
@abellina