Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Memcheck global read error in DistinctJoinTest.IntegerInnerJoin #15156

Closed
davidwendt opened this issue Feb 27, 2024 · 0 comments · Fixed by #15164
Closed

[BUG] Memcheck global read error in DistinctJoinTest.IntegerInnerJoin #15156

davidwendt opened this issue Feb 27, 2024 · 0 comments · Fixed by #15164
Assignees
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@davidwendt
Copy link
Contributor

Found in the nightly builds which run memcheck on libcudf gtests
https://github.com/rapidsai/cudf/actions/runs/8044585263/job/21968419310

[ RUN      ] DistinctJoinTest.IntegerInnerJoin
========= Invalid __global__ read of size 4 bytes
=========     at 0x22e20 in void cudf::detail::<unnamed>::distinct_join_probe_kernel<thrust::transform_iterator<cudf::detail::<unnamed>::build_keys_fn<const cudf::experimental::row::hash::device_row_hasher<cudf::hashing::detail::default_hash, cudf::nullate::DYNAMIC>, cudf::experimental::row::rhs_index_type>, thrust::counting_iterator<int, thrust::use_default, thrust::use_default, thrust::use_default>, thrust::use_default, thrust::use_default>, cuco::static_set_ref<cuco::pair<unsigned int, cudf::experimental::row::lhs_index_type>, (cuda::std::__4::__detail::thread_scope)1, cudf::detail::comparator_adapter<cudf::experimental::row::equality::strong_index_comparator_adapter<cudf::experimental::row::equality::device_row_comparator<(bool)0, cudf::nullate::DYNAMIC, cudf::experimental::row::equality::nan_equal_physical_equality_comparator>>>, cuco::linear_probing<(int)1, cudf::detail::hasher_adapter<thrust::identity<unsigned int>>>, cuco::aow_storage_ref<cuco::pair<unsigned int, cudf::experimental::row::lhs_index_type>, (int)1, cuco::window_extent<int, (unsigned long)18446744073709551615>>, cuco::op::find_tag>>(T1, int, T2, int *, int *, int *)
=========     by thread (244,0,0) in block (3,0,0)
=========     Address 0x7f06d200c68c is out of bounds
=========     and is 5 bytes after the nearest allocation at 0x7f06d2004800 of size 32392 bytes

Use the following to recreate the error

compute-sanitizer --tool memcheck gtests/JOIN_TEST --gtest_filter=DistinctJoinTest.IntegerInnerJoin --rmm_mode=cuda
@davidwendt davidwendt added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. labels Feb 27, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 29, 2024
Closes #15156 
Fixes the invalid global read introduced by #14990 and simplifies the logic.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - David Wendt (https://github.com/davidwendt)

URL: #15164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants