Skip to content

Commit

Permalink
Resolve unnecessary import of thrust/optional.hpp in types.hpp (#7667)
Browse files Browse the repository at this point in the history
Resolves #6475. The missing required include of `optional.hpp` was in `convert_datetime.cu`.

Authors:
  - Vyas Ramasubramani (@vyasr)

Approvers:
  - Conor Hoekstra (@codereport)
  - Jake Hemstad (@jrhemstad)
  - Mark Harris (@harrism)

URL: #7667
  • Loading branch information
vyasr authored Mar 23, 2021
1 parent e07762c commit d500142
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions cpp/include/cudf/io/parquet.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

#include <rmm/mr/device/per_device_resource.hpp>

#include <thrust/optional.h>

#include <iostream>
#include <memory>
#include <string>
Expand Down
4 changes: 1 addition & 3 deletions cpp/include/cudf/types.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2020, NVIDIA CORPORATION.
* Copyright (c) 2018-2021, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -24,8 +24,6 @@
#define CUDA_DEVICE_CALLABLE inline
#endif

#include <thrust/optional.h> // TODO no idea why this is needed ¯\_(ツ)_/¯

#include <cassert>
#include <cstddef>
#include <cstdint>
Expand Down
1 change: 1 addition & 0 deletions cpp/src/lists/explode.cu
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <thrust/binary_search.h>
#include <thrust/iterator/counting_iterator.h>
#include <thrust/iterator/transform_iterator.h>
#include <thrust/optional.h>

#include <memory>
#include <type_traits>
Expand Down
1 change: 1 addition & 0 deletions cpp/src/strings/convert/convert_datetime.cu
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <rmm/device_uvector.hpp>

#include <thrust/logical.h>
#include <thrust/optional.h>

#include <map>
#include <vector>
Expand Down

0 comments on commit d500142

Please sign in to comment.