fix const ptr, remove temp variable

rapidsai · Jul 27, 2021 · b4deb5d · b4deb5d
1 parent 4414f3f
commit b4deb5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/cpp/include/cudf/detail/indexalator.cuh b/cpp/include/cudf/detail/indexalator.cuh
@@ -157,8 +157,7 @@ struct base_indexalator {
    */
   CUDA_HOST_DEVICE_CALLABLE difference_type operator-(T const& rhs) const
   {
-    auto& derived = static_cast<T const&>(*this);
-    return (derived.p_ - rhs.p_) / width_;
+    return (static_cast<T const&>(*this).p_ - rhs.p_) / width_;
   }
 
   /**

diff --git a/cpp/src/replace/nulls.cu b/cpp/src/replace/nulls.cu
@@ -289,8 +289,8 @@ std::unique_ptr<cudf::column> replace_nulls_column_kernel_forwarder::operator()<
 
 template <typename T>
 struct replace_nulls_functor {
-  T* value_it;
-  replace_nulls_functor(T* _value_it) : value_it(_value_it) {}
+  T const* value_it;
+  replace_nulls_functor(T const* _value_it) : value_it(_value_it) {}
   __device__ T operator()(T input, bool is_valid) { return is_valid ? input : *value_it; }
 };