Skip to content

Commit

Permalink
Fix libcudf compile warnings on debug 11.4 build (#9360)
Browse files Browse the repository at this point in the history
This fixes some compile warnings recently added in #9299 and #9278. These warnings are turned into errors on a libcudf Debug build.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9360
  • Loading branch information
davidwendt authored Oct 5, 2021
1 parent fe04d21 commit 6593339
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion cpp/src/copying/gather.cu
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ std::unique_ptr<table> gather(table_view const& source_table,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
CUDF_EXPECTS(gather_map.size() <= std::numeric_limits<size_type>::max(),
CUDF_EXPECTS(gather_map.size() <= static_cast<size_t>(std::numeric_limits<size_type>::max()),
"invalid gather map size");
auto map_col = column_view(data_type{type_to_id<size_type>()},
static_cast<size_type>(gather_map.size()),
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/copying/scatter.cu
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ std::unique_ptr<table> scatter(table_view const& source,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
CUDF_EXPECTS(scatter_map.size() <= std::numeric_limits<size_type>::max(),
CUDF_EXPECTS(scatter_map.size() <= static_cast<size_t>(std::numeric_limits<size_type>::max()),
"invalid scatter map size");
auto map_col = column_view(data_type{type_to_id<size_type>()},
static_cast<size_type>(scatter_map.size()),
Expand Down
4 changes: 1 addition & 3 deletions cpp/src/io/json/json_gpu.cu
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,7 @@ __inline__ __device__ T decode_value(char const* begin,
}

template <typename T, std::enable_if_t<cudf::is_duration<T>()>* = nullptr>
__inline__ __device__ T decode_value(char const* begin,
char const* end,
parse_options_view const& opts)
__inline__ __device__ T decode_value(char const* begin, char const* end, parse_options_view const&)
{
return to_duration<T>(begin, end);
}
Expand Down

0 comments on commit 6593339

Please sign in to comment.