Skip to content

Commit

Permalink
Added newline to end of cmake file and S3 unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
jdye64 committed Jun 9, 2021
1 parent 119f98b commit 21a971b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cpp/cmake/thirdparty/CUDF_GetArrow.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@ endfunction()

set(CUDF_VERSION_Arrow 1.0.1)

find_and_configure_arrow(${CUDF_VERSION_Arrow} ${CUDF_USE_ARROW_STATIC})
find_and_configure_arrow(${CUDF_VERSION_Arrow} ${CUDF_USE_ARROW_STATIC})
13 changes: 5 additions & 8 deletions cpp/tests/io/arrow_io_source_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,27 +61,24 @@ TEST_F(ArrowIOTest, URIFileSystem)
ASSERT_EQ(2, tbl.tbl->num_rows());
}

/*
// This S3 object is currently to large to run in CI. This test can be ran locally however
TEST_F(ArrowIOTest, URIFileSystem)
TEST_F(ArrowIOTest, S3FileSystem)
{
std::string s3_uri = "s3://ursa-labs-taxi-data/2010/06/data.parquet?region=us-east-2";
std::string s3_uri = "s3://rapidsai-data/cudf/test/tips.parquet?region=us-east-2";
std::unique_ptr<cudf::io::arrow_io_source> datasource =
std::make_unique<cudf::io::arrow_io_source>(s3_uri);

// Populate the Parquet Reader Options
cudf::io::source_info src(datasource.get());
std::vector<std::string> single_column;
single_column.insert(single_column.begin(), "dropoff_at");
single_column.insert(single_column.begin(), "total_bill");
cudf::io::parquet_reader_options_builder builder(src);
cudf::io::parquet_reader_options options = builder.columns(single_column).build();

// Read the Parquet file from S3
cudf::io::table_with_metadata tbl = cudf::io::read_parquet(options);

ASSERT_EQ(1, tbl.tbl->num_columns()); // Only single column specified in reader_options
ASSERT_EQ(14825128, tbl.tbl->num_rows()); // known number of rows from the S3 file
ASSERT_EQ(1, tbl.tbl->num_columns()); // Only single column specified in reader_options
ASSERT_EQ(244, tbl.tbl->num_rows()); // known number of rows from the S3 file
}
*/

CUDF_TEST_PROGRAM_MAIN()

0 comments on commit 21a971b

Please sign in to comment.