Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no-compression method in converter #443

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Nov 17, 2022

If you want to use no compression method for your converted file, you can set the compression method to None in the converter.

In CLI, you can use --compression option and set it to any string except jpeg.

E.g.,

cucim convert --tile-size 512 --overlap 0 --num-workers 12  --output-filename resize.tiff --compression RAW notebooks/input/TUPAC-TR-467.svs

The converter will then convert the file without any compression.

Need to update test cases once #433 is merged.

Signed-off-by: Gigon Bae [email protected]

@gigony gigony requested a review from a team as a code owner November 17, 2022 01:31
@gigony gigony self-assigned this Nov 17, 2022
@gigony gigony added feature request New feature or request non-breaking Introduces a non-breaking change labels Nov 17, 2022
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor suggestion to make the compression string case insensitive and raise an error on anything other than 'jpeg', 'raw' or 'none'.

python/cucim/src/cucim/clara/converter/tiff.py Outdated Show resolved Hide resolved
python/cucim/src/cucim/clara/cli.py Show resolved Hide resolved
@gigony gigony force-pushed the support_raw_save branch 2 times, most recently from 4a0a684 to c650f7d Compare November 17, 2022 05:26
If you want to use no compression method for your converted file,
you can set the compression method to None in the converter.

In CLI, you can use `--compression` option and set it to any string
except `jpeg`.

E.g,

  cucim convert --tile-size 512 --overlap 0 --num-workers 12 \
      --output-filename resize.tiff --compression RAW \
      notebooks/input/TUPAC-TR-467.svs

The converter will then convert the file without any compression.

Signed-off-by: Gigon Bae <[email protected]>
@grlee77 grlee77 added this to the v22.12.00 milestone Nov 17, 2022
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks

@grlee77
Copy link
Contributor

grlee77 commented Nov 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7eea9dc into rapidsai:branch-22.12 Nov 18, 2022
@gigony
Copy link
Contributor Author

gigony commented Nov 18, 2022

Thanks a lot @grlee77 for handling/merging this and #433 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants