-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support no-compression method in converter #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor suggestion to make the compression string case insensitive and raise an error on anything other than 'jpeg', 'raw' or 'none'.
4a0a684
to
c650f7d
Compare
If you want to use no compression method for your converted file, you can set the compression method to None in the converter. In CLI, you can use `--compression` option and set it to any string except `jpeg`. E.g, cucim convert --tile-size 512 --overlap 0 --num-workers 12 \ --output-filename resize.tiff --compression RAW \ notebooks/input/TUPAC-TR-467.svs The converter will then convert the file without any compression. Signed-off-by: Gigon Bae <[email protected]>
c650f7d
to
73aea90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks
@gpucibot merge |
If you want to use no compression method for your converted file, you can set the compression method to None in the converter.
In CLI, you can use
--compression
option and set it to any string exceptjpeg
.E.g.,
The converter will then convert the file without any compression.
Need to update test cases once #433 is merged.
Signed-off-by: Gigon Bae [email protected]