Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libGL to image dependencies. #31

Closed
wants to merge 1 commit into from
Closed

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 3, 2023

Potential fix for OpenCV issues in rapidsai/cucim#471.

(There are alternative fixes to consider, so this PR may be closed if another route is taken.)

@bdice
Copy link
Contributor Author

bdice commented Jan 3, 2023

We are adopting another solution here: rapidsai/cucim@6045729

@bdice bdice closed this Jan 3, 2023
@jakirkham
Copy link
Member

Is there more context on why this is being closed and that option being chosen?

@bdice
Copy link
Contributor Author

bdice commented Jan 4, 2023

@jakirkham I discussed on a call with @ajschmidt8. We decided to retain the same testing method that cucim used previously (pip install opencv-python-headless) because it was working in Jenkins (gpuCI).

To use conda packages of opencv (which require libGL), we'd have to install libGL into our CI images (which was not present in the old CI images either). We'd like to avoid adding specific apt/yum dependencies to the base images unless there is no way around it. In this case, there is a status quo solution (use the "headless" pip package) which retains cucim's existing testing strategy and doesn't change our CI images.

There are a couple discussions about creating "headless" opencv conda-forge packages that do not depend on libGL, which we would benefit from having:

"Headless" versions of opencv already exist on other channels such as fastai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants