Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CUDA 12.2 #101

Merged
merged 6 commits into from
Jan 4, 2024
Merged

add CUDA 12.2 #101

merged 6 commits into from
Jan 4, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#7.

Blocked by rapidsai/miniforge-cuda#56.

  • adds CUDA 12.2 images for ci-conda, ci-wheel, and citestwheel
  • drops builds of CUDA 12.1 images

How is it safe to stop generating CUDA 12.1 images?

According to the description in #53, those 12.1.1 images were added for "local testing". It seems they're not being used for anything other than that.

This project is currently only generating rapidsai/ci-conda images for CUDA 12.1.

ci-imgs/matrix.yaml

Lines 31 to 39 in a02c2e8

# exclude citestwheel and ci-wheel for cuda versions other than 11.8.0 and 12.0.1
- CUDA_VER: "11.4.3"
IMAGE_REPO: "citestwheel"
- CUDA_VER: "11.4.3"
IMAGE_REPO: "ci-wheel"
- CUDA_VER: "12.1.1"
IMAGE_REPO: "citestwheel"
- CUDA_VER: "12.1.1"
IMAGE_REPO: "ci-wheel"

Every use of rapidsai/ci-conda I could find (GitHub search) is using either the CUDA 11.8.0 images directly, or :latest.

:latest for ci-conda is rapidsai/ci-conda:cuda12.0.1-ubuntu22.04-py3.10, and this PR doesn't change that:

ci-imgs/latest.yaml

Lines 1 to 5 in a02c2e8

# Define the values used for the "latest" tag
conda:
CUDA_VER: "12.0.1"
PYTHON_VER: "3.10"
LINUX_VER: "ubuntu22.04"

Notes for Reviewers

12.2.2 is the latest tag I see for the 12.2.x series at https://hub.docker.com/r/nvidia/cuda/tags?page=1&name=12.2.

@jameslamb jameslamb marked this pull request as ready for review December 20, 2023 16:25
@jameslamb jameslamb marked this pull request as draft December 20, 2023 16:27
@jameslamb jameslamb marked this pull request as ready for review December 20, 2023 17:09
@jameslamb jameslamb requested review from vyasr and bdice January 2, 2024 21:16
@jameslamb
Copy link
Member Author

Thank you both! I'll merge this and move on to testing with shared-workflows today.

@jameslamb jameslamb merged commit ac6775f into rapidsai:main Jan 4, 2024
324 checks passed
@jameslamb jameslamb deleted the cuda-12 branch January 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants