Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flake8 to fix false positive with Python 3.12 #101

Closed
14 tasks done
bdice opened this issue Sep 17, 2024 · 3 comments
Closed
14 tasks done

Update flake8 to fix false positive with Python 3.12 #101

bdice opened this issue Sep 17, 2024 · 3 comments
Assignees
@bdice @jameslamb

Comments

@bdice
Copy link
Contributor

bdice commented Sep 17, 2024 •
edited by jakirkham
Loading

This issue is a tracking issue for a problem that shows up with older flake8 versions and Python 3.12. We updated the CI images to use Python 3.12 in the latest tag (rapidsai/ci-imgs#188), which is picked up by style check jobs across RAPIDS. See #40 for the broader Python 3.12 tracking issue.

PRs we need to merge:
@bdice
Copy link
Contributor Author

bdice commented Sep 17, 2024

Future steps that could help:

  • Update all these repos to use ruff. It has autofixes, which would have made this process faster even if ruff had the same bug.
  • Update pre-commit hooks on a regular basis to pre-empt this kind of problem.

@jameslamb jameslamb mentioned this issue Sep 18, 2024
Merged
AjayThorve pushed a commit to rapidsai/jupyterlab-nvdashboard that referenced this issue Sep 24, 2024
@jameslamb
update pre-commit hook versions, mark wheels as pure python (#205)
cbef6a8 
We recently observed some issues with Python 3.12 + older `flake8`
versions across RAPIDS:
rapidsai/build-planning#101.

This proposes updating all the pre-commit hooks in this repo
(`pre-commit autoupdate`) to avoid such issues the next time someone
comes to push new commits here.

While doing this, I also discovered that wheel CI here was broken by
rapidsai/shared-workflows#213 (see
#205 (comment)).
This fixes that as well.
@jakirkham
Copy link
Member

jakirkham commented Sep 24, 2024 •
edited
Loading

We discussed this in our meeting today. Sounds like the last piece was resolved in jupyterlab-nvdashboard. Closing this out as resolved

If I've missed something, please feel free to reopen

Thanks all! 🙏

@jameslamb
Copy link
Member

Yep that's right, this is done. Thanks @jakirkham

@jameslamb jameslamb mentioned this issue Sep 25, 2024
Open
@jameslamb jameslamb mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdice bdice

@jameslamb jameslamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakirkham @bdice @jameslamb