Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.18 and use some generics #625

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Update to go 1.18 and use some generics #625

merged 1 commit into from
Apr 28, 2022

Conversation

rowanseymour
Copy link
Contributor

It's already on its first minor release so feels safe to start dipping our toes in here...

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #625 (0eddbfd) into main (f06fb72) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   61.99%   61.93%   -0.06%     
==========================================
  Files         130      130              
  Lines       12859    12839      -20     
==========================================
- Hits         7972     7952      -20     
  Misses       4031     4031              
  Partials      856      856              
Impacted Files Coverage Δ
core/models/contacts.go 63.66% <100.00%> (ø)
core/models/sessions.go 54.86% <100.00%> (ø)
core/models/utils.go 80.43% <100.00%> (-5.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06fb72...0eddbfd. Read the comment docs.

@rowanseymour rowanseymour merged commit cbb3587 into main Apr 28, 2022
@rowanseymour rowanseymour deleted the generics branch April 28, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants