Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move search into its own package and add more tests #620

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #620 (241c617) into main (3314713) will decrease coverage by 0.90%.
The diff coverage is 77.85%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   62.88%   61.98%   -0.91%     
==========================================
  Files         128      130       +2     
  Lines       12840    12848       +8     
==========================================
- Hits         8075     7964     -111     
- Misses       3890     4029     +139     
+ Partials      875      855      -20     
Impacted Files Coverage Δ
core/models/groups.go 23.25% <ø> (-37.67%) ⬇️
core/tasks/contacts/populate_dynamic_group.go 62.50% <60.00%> (ø)
core/search/groups.go 63.63% <63.63%> (ø)
core/search/search.go 70.33% <83.33%> (ø)
core/search/queries.go 94.23% <94.23%> (ø)
core/tasks/starts/worker.go 53.89% <100.00%> (ø)
web/contact/search.go 78.02% <100.00%> (ø)
web/flow/start.go 62.50% <100.00%> (-24.27%) ⬇️
core/models/campaigns.go 33.78% <0.00%> (-15.21%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3314713...241c617. Read the comment docs.

@rowanseymour rowanseymour merged commit 6f2118f into main Apr 20, 2022
@rowanseymour rowanseymour deleted the search_cleanup branch April 20, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant