Update django 5.1 #197
Update django 5.1 #197
Conversation
| migrations.AlterIndexTogether( | ||
| name="dashblock", | ||
| index_together={("org", "is_active", "dashblock_type", "priority")}, | ||
| migrations.AddIndex( |
There was a problem hiding this comment.
We need to adjust these old migrations to not use index_together as that throw the error
TypeError: 'class Meta' got invalid attribute(s): index_together
There was a problem hiding this comment.
I don't think that's true.. Django 5.1 still has AlterIndexTogether for backwards compatibility - you just can't use index_together on a model
There was a problem hiding this comment.
Okay I will step through the codes and see why that error is being thrown
There was a problem hiding this comment.
Need to squash migrations before moving to 5.1 so that no index_together is used in historical migrations
https://docs.djangoproject.com/en/5.1/releases/4.2/#index-together-option-is-deprecated-in-favor-of-indexes
There was a problem hiding this comment.
@rowanseymour even with squashing the migrations we still need to adjust them to not use index_together
No other solution has been provided even on the tickets
There was a problem hiding this comment.
I think in our case we can just even skip the squash migrations and just adjust the past migrations
There was a problem hiding this comment.
And editing the squashed migrations or existing migrations is what is suggested by https://code.djangoproject.com/ticket/34525#comment:17
There was a problem hiding this comment.
Ugh... ok then sorry I was wrong about that.. I think go ahead and manually tweak old migrations if that's the easiest way forward
norkans7
force-pushed
the
update-django-5.1
branch
from
9936f8b
to
4ba35ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 29 29
Lines 1845 1845
=======================================
Hits 1722 1722
Misses 123 123 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
update-django-5.1
branch
from
4ba35ef
to
1860a8f
Compare
norkans7
changed the base branch from
update-deps
to
start-squash-migrations-5.0.8
norkans7
force-pushed
the
update-django-5.1
branch
from
1860a8f
to
4be9e6e
Compare
norkans7
force-pushed
the
update-django-5.1
branch
from
4be9e6e
to
ad81190
Compare
norkans7
changed the base branch from
start-squash-migrations-5.0.8
to
update-deps
norkans7
force-pushed
the
update-django-5.1
branch
from
ad81190
to
c1b5ee0
Compare
norkans7
force-pushed
the
update-django-5.1
branch
from
c1b5ee0
to
d1c17e3
Compare
once #196 is merged