-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FindPython] Work around PyPy bug #13
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6b6c3cd
use FindPython
maxbachmann d10cf58
build from sdist
maxbachmann ed6a086
next try
maxbachmann ca9c59c
fix patch
maxbachmann c200a9b
enable pypy on Windows
maxbachmann 6c0e37f
update scikit-build to master
maxbachmann 84fa385
build in verbose mode
maxbachmann dae558b
Merge branch 'main' into FindPython
maxbachmann d30babb
Update releasebuild.yml
maxbachmann ac9b1e3
Update CMakeLists.txt
maxbachmann 41d4890
WIP: Try SOABI
henryiii 201f469
WIP: try manipulating the SOABI
henryiii 665721b
Update CMakeLists.txt
henryiii 5f84240
Update CMakeLists.txt
henryiii 42c2f9a
Update CMakeLists.txt
henryiii 95cb679
WIP: try manipulating the SOABI
henryiii da1296b
Update CMakeLists.txt
henryiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,8 @@ function(create_cython_target _name) | |
endfunction(create_cython_target) | ||
|
||
create_cython_target(_initialize_cpp) | ||
add_library(_initialize_cpp MODULE ${_initialize_cpp}) | ||
Python_add_library(_initialize_cpp MODULE WITH_SOABI ${_initialize_cpp}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only PyPy seems to care if this is missing. Maybe to avoid reading a CPython .so? |
||
target_compile_features(_initialize_cpp PUBLIC cxx_std_14) | ||
target_include_directories(_initialize_cpp PRIVATE ${RF_CAPI_PATH} ${JW_BASE_DIR}/jarowinkler) | ||
target_link_libraries(_initialize_cpp PRIVATE jaro_winkler::jaro_winkler) | ||
python_extension_module(_initialize_cpp) | ||
install(TARGETS _initialize_cpp LIBRARY DESTINATION src/jarowinkler) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required but simpler.