Safety checks on product options

rapidez · Oct 19, 2023 · 3828e88 · 3828e88
1 parent b01db37
commit 3828e88
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/resources/views/product/partials/options.blade.php b/resources/views/product/partials/options.blade.php
@@ -2,7 +2,7 @@
     <div class="flex flex-col space-y-3">
         @foreach($product->options->sortBy('sort_order') as $option)
             <div>
-                @include('rapidez::product.partials.options.'.($option->type_id ?? $option->type))
+                @includeIf('rapidez::product.partials.options.'.($option->type_id ?? $option->type))
             </div>
         @endforeach
     </div>

diff --git a/src/Models/ProductOption.php b/src/Models/ProductOption.php
@@ -30,7 +30,7 @@ public function product()
     protected function title(): Attribute
     {
         return Attribute::make(
-            get: fn () => $this->titles->firstForCurrentStore()->title,
+            get: fn () => $this->titles->firstForCurrentStore()->title ?? null,
         )->shouldCache();
     }
 

diff --git a/src/Models/ProductOptionTypeValue.php b/src/Models/ProductOptionTypeValue.php
@@ -26,7 +26,7 @@ public function option()
     protected function title(): Attribute
     {
         return Attribute::make(
-            get: fn () => $this->titles->firstForCurrentStore()->title,
+            get: fn () => $this->titles->firstForCurrentStore()->title ?? null,
         )->shouldCache();
     }
 

diff --git a/src/Models/QuoteItemOption.php b/src/Models/QuoteItemOption.php
@@ -48,7 +48,7 @@ protected function value(): Attribute
     protected function label(): Attribute
     {
         return Attribute::make(
-            get: fn () => $this->option?->titles->firstForCurrentStore()->title
+            get: fn () => $this->option?->titles->firstForCurrentStore()->title ?? null
         )->shouldCache();
     }