Build mingw build on Github actions #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Apr 27, 2023
| - name: Compile | ||
| run: | | ||
| cd c/meterpreter | ||
| script --return --command 'make docker' |
There was a problem hiding this comment.
The docker command which eventually gets called runs with -it:
metasploit-payloads/c/meterpreter/Makefile
Lines 291 to 292 in 41800bb
which requires a pty, so we have to wrap it in script
adfoster-r7
force-pushed
the
build-mingw-build-on-github-actions
branch
from
5c4e359
to
5e769a9
Compare
|
@msjenkins-r7 retest this please |
smcintyre-r7
approved these changes
Apr 27, 2023
jmartin-tech
approved these changes
Apr 27, 2023
Merged
zeroSteiner
added a commit
to zeroSteiner/metasploit-framework
that referenced
this pull request
Apr 27, 2023
Includes changes from: * rapid7/metasploit-payloads#639 * rapid7/metasploit-payloads#634
zeroSteiner
added a commit
to zeroSteiner/metasploit-framework
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mingw build on Github Actions
I don't believe mingw builds are currently verified as part of the CI process - let me know if I'm wrong here.