Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
-This PR re-enables the Black Python linter/formatter in the insightconnect-plugins repo. Black version 21.4b0 fixes a breaking issue that caused inconsistent formatting issues.
Testing
This PR was tested by running
black .
on the repository, and checking the results with the Black branched GitHub Action workflow runningblack . --check
.PR Requirements
Developers, verify you have completed the following items by checking them off:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblekomand/python-3-37-slim-plugin
andkomand/python-3-37-plugin
make validate
which callsmdl
to linthelp.md
Functional Checklist
tests/
directory created withicon-plugin run -c sample $action > tests/$action.json
tests/$action_bad.json
icon-plugin run -T tests/example.json --debug --jq
icon-plugin run -T all --debug --jq
(use PR format at end)icon-plugin run -R tests/example.json --debug --jq
icon-plugin run -R all --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
make validate
and make sure everything passesicon-plugin run -A -R all -T all
. For single action validation:icon-plugin run -A -R tests/my_action.json -T tests/my_action.json
icon-plugin ... | pbcopy
) and paste the output in a new post on this PR.