[SOAR-17954] Powershell - Updating help.md and snyk vulnerabilities #2879
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmurray-r7
changed the title
rmurray-r7
requested review from
rbowden-r7,
cmcnally-r7,
ablakley-r7,
igorski-r7,
dlaverty-r7,
joneill-r7,
ekelly-r7 and
nmccullagh-r7
rbowden-r7
reviewed
Oct 17, 2024
dlaverty-r7
approved these changes
Oct 17, 2024
dlaverty-r7
approved these changes
Oct 17, 2024
ekelly-r7
approved these changes
Oct 18, 2024
| @@ -152,6 +153,10 @@ Example output: | |||
|
|
|||
| ## Troubleshooting | |||
|
|
|||
| The use of round-robin DNS lookups is not supported | |||
|
|
|||
| Currently we do not support the use of round-robin DNS lookups. | |||
There was a problem hiding this comment.
Suggested change
| Currently we do not support the use of round-robin DNS lookups. |
I think u need to refresh or something, not sure why this is here twice
igorski-r7
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Could you please add new-line at the end of file? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Ticket: https://rapid7.atlassian.net/browse/SOAR-17954
With a recent customer issue, it seems Round Robin is not support and prevents the user from using the plugin, so further information has been added in the
help.mdto inform the customer of this.Addressing Snyk vulnerabilities and bumping the SDK and performing a plugin refresh.
Describe the proposed changes:
cryptographyandrequestsin requirements.txtRound Robinis not supportedTesting
Ran Snyk internally and it now passes:
