Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: CI crash in test_power_chi2 [WIP] #344

Merged
merged 6 commits into from
Feb 22, 2023
Merged

hotfix: CI crash in test_power_chi2 [WIP] #344

merged 6 commits into from
Feb 22, 2023

Conversation

raphaelvallat
Copy link
Owner

No description provided.

@raphaelvallat raphaelvallat added the docs/testing:book: Documentation and unit testing label Feb 22, 2023
@raphaelvallat raphaelvallat self-assigned this Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 98.59% // Head: 98.53% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (da3d656) compared to base (6f4a7b4).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   98.59%   98.53%   -0.06%     
==========================================
  Files          19       19              
  Lines        3351     3353       +2     
  Branches      544      545       +1     
==========================================
  Hits         3304     3304              
- Misses         25       26       +1     
- Partials       22       23       +1     
Impacted Files Coverage Δ
pingouin/correlation.py 98.08% <0.00%> (-0.64%) ⬇️
pingouin/effsize.py 100.00% <ø> (ø)
pingouin/power.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat
Copy link
Owner Author

The range on which the chi-square effect size was evaluated was unecessary too large and caused a Python crash in latest version of SciPy

@raphaelvallat raphaelvallat marked this pull request as ready for review February 22, 2023 21:11
@raphaelvallat raphaelvallat merged commit 8c92b6d into master Feb 22, 2023
@raphaelvallat raphaelvallat deleted the fix_ci branch February 22, 2023 21:12
@musicinmybrain
Copy link
Contributor

I spotted this failure in Fedora 39/Rawhide (and noted that it will soon affect Fedora 38/Branched). I can confirm that applying this PR as a downstream patch to 0.5.3 fixes the problem in Fedora, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/testing:book: Documentation and unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants