Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed 'r' with 'pointbiserialr' in convert_effsize #325

Merged
merged 3 commits into from
Dec 18, 2022

Conversation

raphaelvallat
Copy link
Owner

@raphaelvallat raphaelvallat commented Dec 18, 2022

Closes #302

Tasks

  • Update notebook
  • Update changelog

@raphaelvallat raphaelvallat self-assigned this Dec 18, 2022
@raphaelvallat raphaelvallat added the bug 💥 Something isn't working label Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 98.59% // Head: 98.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7af2fb0) compared to base (cdb5831).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          19       19           
  Lines        3347     3349    +2     
  Branches      541      542    +1     
=======================================
+ Hits         3300     3302    +2     
  Misses         25       25           
  Partials       22       22           
Impacted Files Coverage Δ
pingouin/utils.py 92.45% <ø> (ø)
pingouin/effsize.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat raphaelvallat marked this pull request as ready for review December 18, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pearson's r from compute_effsize =|= Pearson's r from convert_effsize
1 participant