Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distribution.py #310

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Conversation

ALL-SPACE-Rob
Copy link
Contributor

Fix statistical test on line 439 for anderson().

Fix statistical test on line 439 for anderson().
@raphaelvallat raphaelvallat self-requested a review November 1, 2022 18:40
@raphaelvallat raphaelvallat added bug 💥 Something isn't working URGENT ⚠️ To fix ASAP labels Nov 1, 2022
@raphaelvallat
Copy link
Owner

raphaelvallat commented Nov 1, 2022

Awesome, thanks. Remaining tasks (for self):

  • Add unit test
  • Update docstring
  • Update changelog
  • Add to release roadmap

@raphaelvallat raphaelvallat linked an issue Nov 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 98.70% // Head: 98.67% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (41cb291) compared to base (628fd53).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   98.70%   98.67%   -0.04%     
==========================================
  Files          18       18              
  Lines        3312     3312              
  Branches      537      537              
==========================================
- Hits         3269     3268       -1     
  Misses         25       25              
- Partials       18       19       +1     
Impacted Files Coverage Δ
pingouin/distribution.py 99.41% <100.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat raphaelvallat merged commit 6816d02 into raphaelvallat:master Nov 25, 2022
@raphaelvallat
Copy link
Owner

Merged after a few edits. Thanks again!

@ALL-SPACE-Rob
Copy link
Contributor Author

Merged after a few edits. Thanks again!

No worries - thanks for all the help! Happy Thanksgiving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working URGENT ⚠️ To fix ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anderson() boolean returned value is inverted
2 participants