-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle single-sample comparsion in pairwise_test #299
Conversation
Hi @George3d6, Thank you for this!
|
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 98.75% 98.71% -0.05%
==========================================
Files 19 19
Lines 3298 3335 +37
Branches 529 537 +8
==========================================
+ Hits 3257 3292 +35
- Misses 24 25 +1
- Partials 17 18 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'm actually unsure when the scipy interface might have changed, or if this was always the case, I'll look into it. |
@raphaelvallat as far as I can see this isn't a recent change in the scipy interface as I suspected, so I guess the bug was always there. |
Got it, well I think we're good to merge. Thanks again for the PR! |
Due to a scipy interface change the pairwise_test can fail when obtaining the t-value from a single sample comparison, this, I believe, fixes that issue.